Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harnesses for safety of primitive conversions #233

Merged

Conversation

ShoyuVanilla
Copy link

@ShoyuVanilla ShoyuVanilla commented Dec 21, 2024

Towards #220

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@ShoyuVanilla ShoyuVanilla requested a review from a team as a code owner December 21, 2024 19:08
@ShoyuVanilla ShoyuVanilla force-pushed the challenge-14 branch 5 times, most recently from 140887c to 26512c1 Compare December 23, 2024 13:05
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShoyuVanilla ShoyuVanilla force-pushed the challenge-14 branch 5 times, most recently from 5ebcf38 to 8ebf05f Compare January 3, 2025 23:54
@ShoyuVanilla ShoyuVanilla force-pushed the challenge-14 branch 3 times, most recently from 6efe1d0 to 226ae4c Compare January 22, 2025 04:59
@carolynzech
Copy link

Hi @ShoyuVanilla -- is this ready for re-review? (And if so, can you request re-review from @tautschnig and I?)

Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful macros! I'd ask that you write brief comments above each of them just explaining what they do--especially the distinction between the infallible macro and the harness_pass one, since that's a bit subtle.

Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tautschnig tautschnig added this pull request to the merge queue Feb 11, 2025
Merged via the queue into model-checking:main with commit ff0b5bf Feb 11, 2025
15 of 16 checks passed
@ShoyuVanilla ShoyuVanilla deleted the challenge-14 branch February 27, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants